Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC failed to build C++ mrbgems. #2588

Closed
dyama opened this issue Sep 8, 2014 · 3 comments
Closed

MSVC failed to build C++ mrbgems. #2588

dyama opened this issue Sep 8, 2014 · 3 comments

Comments

@dyama
Copy link

dyama commented Sep 8, 2014

Build.enable_cxx_abi method in 'mruby_build.rake' set cxx.command value into linker.command.
In case of my MSVC, cxx.command is 'cl.exe' and linker.command is 'link.exe'. When after the method, cl.exe in linker.command does not receive the options for linker and it crashed.

I tried comment out 'linker.command = cxx.command' line, it's running well.

I don't understand about ABI well, so I cannot fix it myself, and I have no good idea.

NOTE: My MSVC is v9(too old?). The C++ mrbgem has no problem in my linux with g++.

Thanks.

@take-cheeze
Copy link
Contributor

Ah, sorry I didn't think about MSVC.
Does this patch work?

@dyama
Copy link
Author

dyama commented Sep 8, 2014

Thanks for your patch.
The rake is working fine!

@take-cheeze
Copy link
Contributor

@dyama Thanks for testing. Should be merged as #2589.

@matz matz closed this as completed in 380be0e Sep 8, 2014
matz added a commit that referenced this issue Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants