Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test_runtime.sh into a go program #8

Open
mrunalp opened this issue Nov 12, 2015 · 5 comments
Open

Convert test_runtime.sh into a go program #8

mrunalp opened this issue Nov 12, 2015 · 5 comments

Comments

@mrunalp
Copy link
Owner

mrunalp commented Nov 12, 2015

No description provided.

@liangchenye
Copy link

The similar go implementation is here:
https://github.com/huawei-openlab/oct/blob/master/validate.go
But that is designed for testing multiple cases.
I'd like to prepare a single-case one based on your test_runtime.sh and the change in #7 .

I have a question, where should we put the new program to?
It is higher level of the current ocitools.

@mrunalp
Copy link
Owner Author

mrunalp commented Nov 16, 2015

@liangchenye We can have a program here that takes a path to a rootfs and a test case to start with.

@liangchenye
Copy link

The go program is here: https://github.com/liangchenye/ocitools/blob/master/testRuntime.go which is made from oct/validate.go. The command line is not supported yet. Should it became a part of main.go?

@mrunalp
Copy link
Owner Author

mrunalp commented Nov 21, 2015

@liangchenye Nice! I think it should be a part of main.go. There is a validate which I intended for spec validation. Maybe --runtime or a separate command for runtime validation.

@liangchenye
Copy link

@mrunalp new PR submitted.
That is used to verify if a bundle was valid. The code was modified from bundleValidator in OCT.
I think it is the 'spec validation' right?

Once the hashing and the archival format are defined in OCI, the relevant codes will also be added to bundle.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants