Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerController issues during rotation #9

Closed
adamdahan opened this issue Oct 23, 2020 · 6 comments
Closed

ContainerController issues during rotation #9

adamdahan opened this issue Oct 23, 2020 · 6 comments

Comments

@adamdahan
Copy link

adamdahan commented Oct 23, 2020

Hey

I am having an issue where the my Apps orientation settings are all off and the app is only supposed to work in Portrait but one of my view controllers uses your ContainerController. The problem is, when you rotate the device upside down just for fun -> Your ContainerController goes bezerk and jumps all over the place.

Are you aware of this issue?

@adamdahan
Copy link
Author

The culprit of the issue is "rotated" in ContainerController. It does not respect if the phone has orientation disabled.

@duchuy-13
Copy link

@adamdahan hey I have same issue, and I found the work around for this is:

container = ContainerController(addTo: self, layout: layout)
NotificationCenter.default.removeObserver(container, name: UIDevice.orientationDidChangeNotification, object: nil)

@mrustaa
Copy link
Owner

mrustaa commented Feb 3, 2021

I noticed this problem.
I will try to solve it as soon as possible.

@ahmedraad
Copy link

hello @mrustaa

Is there any fix coming soon?

@mrustaa
Copy link
Owner

mrustaa commented Nov 6, 2021

I fixed it
@adamdahan @ahmedraad Sorry for the long delay in response

@ahmedraad
Copy link

@mrustaa Great, Thanks

@mrustaa mrustaa closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants