Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Join all commands under an umbrella command coverde #16

Closed
kranfix opened this issue Sep 15, 2021 · 2 comments · Fixed by #18
Closed

[RFC] Join all commands under an umbrella command coverde #16

kranfix opened this issue Sep 15, 2021 · 2 comments · Fixed by #18
Labels

Comments

@kranfix
Copy link

kranfix commented Sep 15, 2021

The current trend in Dart CLI is to have a a single ring to rule them all and the currently, this project has two commands: cov and x.

Why not to have a coverde command with the following API:

coverde filter  
coverde value  
coverde rm  

If you agree, I would like to send the PR.

@mrverdant13
Copy link
Owner

mrverdant13 commented Sep 15, 2021

Hey, @kranfix !

That was exactly the initial idea but since the rm command is not strictly related to coverage functionality I decided to isolate it within a "generic actions" parent command (the x command).

However, rm is currently the only command with this cov-independent behavior. Thus, I guess it's just ok to use a single parent command for now as you suggest.

I'll keep an eye on new PRs in case you submit one. Otherwise, I'll be working on this change in the following days.

@mrverdant13
Copy link
Owner

mrverdant13 commented Sep 15, 2021

If new generic commands are included in future releases, it would be handy to nest them within a parent command.
Let's cross that bridge when we come to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants