Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure safe dir path construction #38

Merged
merged 6 commits into from Nov 26, 2021
Merged

Conversation

mrverdant13
Copy link
Owner

Description

For folder structures with single child nested folders, the report tool had issues when generating relative paths. This PR ensures relative path construction is safe.

@mrverdant13 mrverdant13 added the bug Something isn't working label Nov 26, 2021
@mrverdant13 mrverdant13 self-assigned this Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #38 (84b91d2) into main (2f47382) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          454       455    +1     
=========================================
+ Hits           454       455    +1     
Impacted Files Coverage Δ
lib/src/entities/cov_file.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f47382...84b91d2. Read the comment docs.

@mrverdant13 mrverdant13 merged commit fff1ca5 into main Nov 26, 2021
@mrverdant13 mrverdant13 deleted the fix/safe-dir-structure branch November 26, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant