Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmSetupAssistant: Windows: Support for Missing Registry entries #60

Closed
mrwatson-de opened this issue Nov 29, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@mrwatson-de
Copy link
Owner

mrwatson-de commented Nov 29, 2023

Apparently on windows, registry entries can be missing, if a setting has never been changed.

A missing registry entry means that FileMaker uses the setting/behaviour which was default before the setting was introduced.

In this situation the MBS Plugin returns [MBS] Windows Error 2: Das System kann die angegebene Datei nicht finden.

fmSetupAssistant needs to define the default value for this situation!

@mrwatson-de mrwatson-de changed the title fmsa fmSetupAssistant: Windows: Support for Missing Registry entries Nov 29, 2023
@mrwatson-de
Copy link
Owner Author

This situation is in very seldom cases a problem:

  • Actually it is just unsightly to see an error [MBS] Window Error 2:… in the Current Value field
  • fmSetupAssistant will usually just create the new setting, and ignore the error.
  • Should a user manually change the setting without changing the value first, then the MBS error will be written to the setting.
    • This will thus only cause an error when combined with user negligence.

As such this issue is being labeled as an enhancement, rather than a bug.

@mrwatson-de mrwatson-de added the enhancement New feature or request label Nov 29, 2023
@mrwatson-de
Copy link
Owner Author

Solved.

The solution has two aspects:

  • first, recognising that the setting is not present and not outputting the MBS error,
  • second, definition of the correct default value to use, when the registry entry is missing.

There are two types of default value that can be defined:

  1. a GUI value
  • this is the value the user sees in the GUI
  • for example a (GUI) default cache size of 128 (MB) is shown and converted into an internal value of 131072 bytes (=128*1024)
  1. a raw value
  • This is an internal setting value, which is first passed through the conversion calculation in order to display the GUI value
  • for example, the (raw) default script space syntax colour for errors is (something like ) `rgba (1,0.2,0.2) which is converted and shown in the GUI as a red colour.

After selecting GUI or raw the default is considered defined - don't forget to enter the actual value - and test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant