Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors were not right for userInterfaceStyle: "light" #8

Closed
trevorpfiz opened this issue Dec 26, 2023 · 4 comments
Closed

colors were not right for userInterfaceStyle: "light" #8

trevorpfiz opened this issue Dec 26, 2023 · 4 comments

Comments

@trevorpfiz
Copy link

This seems like an expo cache issue.

I had userInterfaceStyle: "light" and when I was first using rnr-ui the colors for buttons for example were too light. I changed to userInterfaceStyle: "dark" and everything looked good. Changed back to userInterfaceStyle: "light" and all the colors were fine?

I had been running expo start -c with no impact. Not sure.

@mrzachnugent
Copy link
Owner

Not sure to understand the issue. What do you mean by "the colors for buttons for example were too light"?

So the colors were too light when you first had userInterfaceStyle: "light", then you switched it to "dark", it worked well, and then you switched it back to "light" and it worked well?

Not sure about the expo caching issue but async-storage is used to persist the theme which might be causing the seemingly caching issue.

@trevorpfiz
Copy link
Author

Hey, sorry for being so vague. Instead of black for a default variant the button was gray, and for destructive it was a pale red instead of what it should be. When I changed the global.css values the colors would change, but not be accurate to what they should be.

I didn't set up the theme provider, just set userInterfaceStyle and copied the components in.

@mrzachnugent
Copy link
Owner

The theme provider is for the navigation so it shouldn't be related.

It could be a nativewind issue (it is still in beta), a difference in versions of dependencies, an issue with your tailwind config, or something else.

Please add a minimal-repoduction repo with the same issue or at the minimum your tailwind config, your css variables, the version of nativewind that you are using, and the code for your button that have the wrong theme.

@trevorpfiz
Copy link
Author

the issue is definitely something with expo or nativewind. I can't reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants