Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load the google client.js script if gapi is undefined #39

Open
jacobcsmith opened this issue Aug 8, 2017 · 0 comments
Open

Only load the google client.js script if gapi is undefined #39

jacobcsmith opened this issue Aug 8, 2017 · 0 comments

Comments

@jacobcsmith
Copy link

We found that incorporating this module significantly slowed down our Angular 1.5 karma-jasmine tests. Since the run block of angular modules are automatically executed for every test we found that the google client.js was repeatedly inserted and loaded and this slowed down the tests. This duplicate client loading could be avoided if the angular-google-plus run function would check to see if gapi was already loaded before proceeding with the google client script insertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant