Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more colour options #32

Closed
ms-jpq opened this issue Aug 5, 2020 · 26 comments
Closed

more colour options #32

ms-jpq opened this issue Aug 5, 2020 · 26 comments

Comments

@ms-jpq
Copy link
Owner

ms-jpq commented Aug 5, 2020

No description provided.

@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 5, 2020

override LS_COLOURS

@Mte90
Copy link
Contributor

Mte90 commented Aug 5, 2020

Maybe also give to filenames the same colors of the icon not everything white as it is now.

@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 5, 2020

those actually follow your LS_COLORS environmental variable, like you can currently use

https://github.com/seebi/dircolors-solarized

or a number of similar projects to add colouring,

@Mte90
Copy link
Contributor

Mte90 commented Aug 6, 2020

I use exa instead of ls with an alias https://the.exa.website/
That is colored, it is possible to use that?

@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 7, 2020

exa also uses LS_COLORS plus some of its own colouring for example on *.pdf files.

I cannot add those exa extras, but I am commited to support all LS_COLORS

@Mte90
Copy link
Contributor

Mte90 commented Aug 7, 2020

It's not clear for me, this tool use ls to generate the list or use the colors that will be used by that command?

@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 7, 2020

No, it parses LS_COLORS variable, which there are lots of presets for such as

https://github.com/seebi/dircolors-solarized

or

https://github.com/trapd00r/LS_COLORS

This is more useful than other colouring schemes because for example +x is almost always coloured as green, or sockets will be often yellow and such. Each colour represents something useful about the files / folders.

@Mte90
Copy link
Contributor

Mte90 commented Aug 7, 2020

Ok now is more clear, thanks!

@ms-jpq ms-jpq mentioned this issue Aug 7, 2020
@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 7, 2020

idea:

emulate more popular file explorers so themes that contain their highlight groups will automatically apply to CHADTree.

@WinWisely268
Copy link

When dircolors are set to the original 16 colors like so:

screenshot_2020-08-08-165240
screenshot_2020-08-08-165301

The colors of CHADTree is not using current terminal colors though:

@Jwwyite
Copy link

Jwwyite commented Aug 11, 2020

When dircolors are set to the original 16 colors like so:

screenshot_2020-08-08-165240
screenshot_2020-08-08-165301

The colors of CHADTree is not using current terminal colors though:

I have the same problem, and I use the same colorscheme. So after seeing your reply I thought that it may be somehow connected to the nord colorscheme. And here's what I got after exporting this https://github.com/seebi/dircolors-solarized/blob/master/dircolors.256dark
pic-full-11-08-2020-22:27:48

@Mte90
Copy link
Contributor

Mte90 commented Aug 27, 2020

In my install tree is getting the LS_COLORS var but in neovim with chadtree no, maybe add a debug system for that?

@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 27, 2020

Ok sorry this issue has been open for a long time, and is the most popular issue. I am not ignoring this, I will add in the new colour options, but maybe it will take longer than expected.

Recently, I got into something great with I person I really like, so ya thats been my all my free time pretty much for the next bit.

@Mte90
Copy link
Contributor

Mte90 commented Aug 28, 2020

No worries, this is open source. If you cannot do it someone else will do that. I already started looking at the code as example to see if I can do something when I have time.

@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 29, 2020

thank you :D

I've been getting zero work done for the past week, its so exciting.

@Mte90
Copy link
Contributor

Mte90 commented Sep 10, 2020

A bit more information after a debugging, if I run nvim from terminal where is the variable chadtree can read the global var.
Else if I run in KDE like with Krunner as I usually do, chadtree is not colored.
Looking at the code I think that a solution can be create a new variable where the user set the path of the script and execute it or parse it as already do.

@Mte90
Copy link
Contributor

Mte90 commented Sep 10, 2020

Right now I patched it in that way but is very dirty solution, on file ls_colours.py line 255:

if ls_colours == '':
        f=open(path.expanduser("~/.vim/bundle/chadtree/_lscolors"), "r")
        ls_colours = f.read()

In _lscolors there is the pure string so chadtree can parse it. I think that we can find a way to add a variable in vimrc to pass the custom string instead of a hardcoded solution like this.

@Mte90
Copy link
Contributor

Mte90 commented Oct 26, 2020

Any updates for this @ms-jpq

@ms-jpq
Copy link
Owner Author

ms-jpq commented Oct 26, 2020

yeah sorry i havn't forgot about this, I just have a bunch of things going on in my life right now that I have higher piority on.

I don't know when I will get to finish this, but I know exactly what I need to do, I will just have to find the time to do it.

@Mte90
Copy link
Contributor

Mte90 commented Jan 9, 2021

It's me again, maybe if you explain there what you want to do I can try to do a pull request, as I am starting to hate the sidebar as it is now and start regretting Nerdtree just for this is not good for my Neovim XD

@ms-jpq
Copy link
Owner Author

ms-jpq commented Jan 10, 2021

please don't make a PR for the moment, im making some big changes in another branch, I guess ill do it in there after i make sure everything still works

https://github.com/ms-jpq/chadtree/tree/future2

i guess it wont be too much effort for me to add it there

@Mte90
Copy link
Contributor

Mte90 commented Jan 10, 2021

I will wait like a kid waiting for the christmas present also if christmas was a few weeks ago :-D

@ms-jpq
Copy link
Owner Author

ms-jpq commented Jan 15, 2021

Some update, I am pretty close to it, the PR is really big, like close to 200 commits, and im sure will easily go over when im done.

Here is what I still need to do:

  1. Add more documentation, the new PR have a command called CHADhelp, and it will open documentation in either a floating window, or a web browser window (assuming u have a web browser installed). Obviously this means that I will need to write up the docs, which is pretty tedious because I want to do a good job at it.

  2. Need to test it pretty extensively, since I basically did a minor rewrite. I do not have access to my machines right now, because I am stuck overseas due to having my flights rekt by covid restrictions. It will take me a day or two of testing on Windows, Linux and MacOS once Im home.

So far everything is looking good though, I will also do a Doc on what I changed, and why. It's very exciting :)

@ms-jpq
Copy link
Owner Author

ms-jpq commented Jan 21, 2021

https://github.com/ms-jpq/chadtree/blob/chad/docs/THEME.md

sneak peak, added 7 colour options for now, and added examples for the 3 icon options.

@ms-jpq ms-jpq closed this as completed Jan 21, 2021
@Mte90
Copy link
Contributor

Mte90 commented Jan 21, 2021

Screenshot_20210121_111914

It works :-D

@ms-jpq
Copy link
Owner Author

ms-jpq commented Jan 21, 2021

:D you should see the improvements I made :D

The new thing also comes with parallel file system walk and react like minimizing renderer.

Gonna make a reddit post about this later but im so tired. over 400 commits...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants