Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lockfile out of sync #85

Closed
grawlinson opened this issue Aug 2, 2021 · 7 comments · Fixed by #87
Closed

Lockfile out of sync #85

grawlinson opened this issue Aug 2, 2021 · 7 comments · Fixed by #87

Comments

@grawlinson
Copy link
Contributor

Building with cargo build --locked fails. Seems like the lockfile has somehow managed to get out of sync.
@ms-jpq
Copy link
Owner

ms-jpq commented Aug 3, 2021

c3a204d

should be ok now, thank you for the report. I thought github's bots would keep it in sync lol

@ms-jpq ms-jpq closed this as completed Aug 3, 2021
@grawlinson
Copy link
Contributor Author

The lockfile is out of sync again, as of version 0.4.11. :(

@ms-jpq
Copy link
Owner

ms-jpq commented Aug 12, 2021

oh fuck me, i knew i fucked up today, forgot to commit after i did my build reeeeeee.

ok so i have a presentation coming up ill fix after the presentation ok

@ms-jpq ms-jpq reopened this Aug 12, 2021
@grawlinson
Copy link
Contributor Author

No worries! Happens to all of us! :)

@alerque
Copy link
Contributor

alerque commented Aug 12, 2021

You can catch this in CI if you include --locked in the CI build system.

@ms-jpq
Copy link
Owner

ms-jpq commented Aug 12, 2021

hey thats a great idea!

ur a genius <3

@alerque alerque mentioned this issue Aug 12, 2021
Merged
@ms-jpq
Copy link
Owner

ms-jpq commented Aug 13, 2021

sorry for the late resp, I rewrote basically half the program to be prettier ^_^

#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CI runs enforce lockfile updates alerque/sad
3 participants
@alerque @grawlinson @ms-jpq