Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with VisualizeMatching #103

Closed
Sidduppal opened this issue Jun 11, 2023 · 4 comments · Fixed by #107
Closed

Error with VisualizeMatching #103

Sidduppal opened this issue Jun 11, 2023 · 4 comments · Fixed by #107

Comments

@Sidduppal
Copy link

Hey Martin, thanks for building this amazing tool. I have been getting the following error when running VisualizeMatching. I tried running VisualizeMatching with the test data you use in the manual and it's running well so I know that the code is working. However, I'm unable to identify why my data is causing this error. Other functions (eg. TreeDistance) seems to be working. Any idea what I could be missing?

Error in if (any(DF[A, ] != DF[B, ])) { :
missing value where TRUE/FALSE needed

Thanks

@ms609
Copy link
Owner

ms609 commented Jun 12, 2023

Hi @Sidduppal ,

Thanks for your interest in the package, glad it's proving useful!

To get to the bottom of this issue, it'd be helpful to know exactly what code you were running when the error arose. If you're also able to share the trees you are comparing (via e-mail if not publicly), that would help me to debug.

Thanks

Martin

@Sidduppal
Copy link
Author

Hey @ms609 can you tell me the email to send to ?

@ms609
Copy link
Owner

ms609 commented Jun 14, 2023

Thanks for sending the trees, which has helped me to pinpoint the error, which is arising because the code does not presently handle unrooted trees. I'll look into supporting this in the coming week or two.

In the meantime, you can try:

VisualizeMatching(ClusteringInfoDist, RootTree(tr1, 1), RootTree(tr2, 1))

@ms609 ms609 linked a pull request Sep 7, 2023 that will close this issue
@ms609
Copy link
Owner

ms609 commented Sep 7, 2023

Sorry it's taken a while to get round to this. I think I have a fix in hand. Would you be able to test your trees against the patch?
(Install with devtools::install_github("ms609/TreeDist", ref = "103-error-with-visualizematching"))

@ms609 ms609 closed this as completed in #107 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants