Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress Powershell popping up in pyinstaller .exe #18

Merged
merged 1 commit into from Nov 2, 2020
Merged

Supress Powershell popping up in pyinstaller .exe #18

merged 1 commit into from Nov 2, 2020

Conversation

dynobo
Copy link
Contributor

@dynobo dynobo commented Nov 2, 2020

Hi, I noticed a bug of notify-py in combination with PyInstaller on Windows (10):
If a program using notify-py is compiled to an .exe with the --windowed flag, the powershell windows pop's up for second when a notification is shown.

This commit should fix it.

To reproduce:

  1. Deps:
    pip install pyinstaller notify-py
  2. Create test.py:
    from notifypy import Notify
    notification = Notify()
    notification.send(block=False)
  3. Compile to .exe:
    pyinstaller --windowed test.py
  4. Run ./dist/test/test.exe

Result:
powershell

@dynobo
Copy link
Contributor Author

dynobo commented Nov 2, 2020

Uh, black throws error on files I didn't touch:

[...]
would reformat /home/runner/work/notify-py/notify-py/notifypy/cli.py
would reformat /home/runner/work/notify-py/notify-py/notifypy/notify.py

Shall I reformat and commit again?

@ms7m
Copy link
Owner

ms7m commented Nov 2, 2020

Don't worry about that, I'll handle it.
Thanks for PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants