Improvements | notify-send | Urgerncy | Which | BSD

[GiorgosXou]

notify-py/notifypy/os_notifiers/linux.py

Line 33 in f748189

I'll add support for (and probably use as first choice) sending

• Added: notification urgency (low, normal, critical) for notify-send
• Fixed: notify-send, now is being used as the first choice if installed
• Fixed: OSs like BSD now default under the linux-behavioural category
• Fixed: issue under windows with extra kwargs that resulted in error
• Removed: linux_fallback_libnotify, no more need for it
• Replaced: functions with the in-built shutil.which function

PS. Tried not to be messy with the code and respect your overall structural patterns. It has been tested and works fine both on linux and on windows (+the in-built shutil.which function works with BSD too)

[GiorgosXou]

6 changes + 1 for the improvments + 0.3.31 = 0.3.38

Removal of linux_fallback_libnotify wont effect users that have forced a fallback to libnotify

[ms7m]

This looks really good, and I'll merge these changes as well as some overdue patches things such as #40 and PRs #39 !

[ms7m]

Don't worry about the tests either, that's also overdue for some changes :-)

[GiorgosXou]

• update loguru to 0.6.0 #40 seems to be already fixed

  notify-py/pyproject.toml

  Line 16 in f748189

  loguru = "^0.5.3,<=6.0"

• I just merged the change of Inherit correct Exception class #39
• fix typo #37 should be closed. (function has been replaced by the in-built shutil.which)
• ✔️ Tested briefly, works fine

[ms7m]

Fantastic!! Thanks so much -- I'm gonna do a PR ( #48 ) to fix up the tests and fix the issue in #46.. This shouldn't cause any conflicts with your contribution

once that's done feel free to pull that in to your branch and we can publish!

[GiorgosXou]

Done ✔️ (sorry for the slightly weird commit message lol)

[GiorgosXou]

I'm working on a project that I want to upload in the next days, which uses this package... So.. would you mind to speed up a bit the process of publishing?

[ms7m]

Sure -- Sorry for the delay. Please pull in the latest changes from master and I can merge/publish this version.

[GiorgosXou]

Done ✔️

[ms7m]

Fantastic, I really do appreciate it! 🎉