Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Component System? #10

Open
msakuta opened this issue Jul 5, 2021 · 7 comments
Open

Entity Component System? #10

msakuta opened this issue Jul 5, 2021 · 7 comments

Comments

@msakuta
Copy link
Owner

msakuta commented Jul 5, 2021

ECS and Rust seems to get along well:
https://youtu.be/aKLntZcp27M

Why not implement it in our game?

I tested with 100 pipes and measured performance in ecs-specs-structure-slice
image

and this is pre-ECS (Box dynamic polymorphism) :
image

@msakuta
Copy link
Owner Author

msakuta commented Jul 11, 2021

I increased number of pipes to 400 to measure differences more accurately.

ECS:
image

pre-ECS (dynamic polymorphism):
image

Clearly both of them scale poorly, but pre-ECS is an order of magnitude faster.

@msakuta
Copy link
Owner Author

msakuta commented Jul 11, 2021

There is a third option, which I call half-baked ECS. The components can be grouped together in the same allocation unit.

pub(crate) struct StructureComponents {
    pub position: Option<Position>,
    pub rotation: Option<Rotation>,
    pub burner: Option<Burner>,
    pub energy: Option<Energy>,
    pub factory: Option<Factory>,
    pub fluid_boxes: Vec<FluidBox>,
}

It is not very good at utilizing memory, since it has a lot of wasted space in absent components, but it performs marginally better than dynamic polymorphism, probably due to less invocations of virtual functions. Also we can always reduce an empty component by putting in a Box or Vec.

image

And we can optimize the fluid simulation even further by calculating connections only something has changed.

image

And dynamic polymorphism is still slower after the optimization, probably due to the virtual function call:

image

@msakuta
Copy link
Owner Author

msakuta commented Jul 14, 2021

Now I implemented generational id so that each structure can hold references to each other that can be dereferenced in constant time.

pub(crate) struct StructureId {
    pub id: u32,
    pub gen: u32,
}

Now the performance with 400 pipes is unmeasurable. (We don't care too much about rendering time here because we won't render the whole map at once and ECS's goal is not to improve rendering performance, and we will migrate to WebGL or WebGPU if we really need rendering performance.)

image

@msakuta
Copy link
Owner Author

msakuta commented Jul 15, 2021

Now I test with 400 chests and inserters that move items in circle!

image

With dynamic polymorphism without generational id optimization:

image

With generational id optimization:

image

So much improvement!

In fact, the most effective optimization is generational id, rather than ECS.

@msakuta
Copy link
Owner Author

msakuta commented Jul 17, 2021

Now testing a lot of wire connections

image

We optimize electricity grid calculation by using a cache data structure called PowerNetwork. Each PowerNetwork contains a list of power sources and sinks as StructureId lists, so the sinks can quickly query sources.

pub(crate) struct PowerNetwork {
    pub wires: Vec<PowerWire>,
    pub sources: HashSet<StructureId>,
    pub sinks: HashSet<StructureId>,
}

Each color of the wires indicate distinct networks in the picture below.

image

with dynamic polymorphism:

image

@msakuta
Copy link
Owner Author

msakuta commented Jul 18, 2021

I ported 400 chests and inserters test with ECS + generational id, and it shows pretty similar performance to dynamic polymorphism.

image

@msakuta
Copy link
Owner Author

msakuta commented Jul 18, 2021

And finally, 400 assemblers and electric wires on half-baked ECS + generational id

image

In conclusion, generational ids improves so much that we can't miss it, and half-baked ECS can further improve the performance 1-2 times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant