Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongol fails to load due to incompatibility with u2622:persistent-session #57

Closed
MichelFloyd opened this issue Mar 19, 2015 · 11 comments
Closed

Comments

@MichelFloyd
Copy link

Uncaught ReferenceError: EJSON is not defined reporters.js?1426735142249:67

Not sure who gets the blame here but I'm going to guess gwendall:session-json might be involved since it's a related package that's installed by mongol.

Found this during Max's presentation at tonight's South Bay Meteor meetup.

@JackAdams
Copy link
Contributor

I think the problem is with u2622:persistent-session. It overwrites the Session functions, whereas gwendall:meteor-session-json just updates the ReactiveVar prototype.

However, this is the most recent commit for u2622:persistent-session, which may address the issue.

If that doesn't help, not sure that we can do much about this. (Except, maybe, give a config option to switch off the editable json.)

@krawalli
Copy link

"EJSON is not defined"

you need to api.use('ejson') in the package.js

@arvi
Copy link

arvi commented Mar 23, 2015

I'm experiencing this too after adding u2622:persistent-session package

No collections found. If you think this is an error, please report it on Github.

It's when I log-in to my app and CTRL+M, this would appear. However, if I did browser refresh at every page I navigate to, CTRL+M will list my subscriptions as expected.

Maybe this would be my workaround for now while this issue is still not resolved. :p

@JackAdams
Copy link
Contributor

@krawalli -- is that in the editable-json package.js file?

@krawalli
Copy link

@JackAdams - its the message from the issue reporter in line 1 - Maybe its from your package.

@JackAdams
Copy link
Contributor

Anyone got a minimal reproduction for this? I couldn't reproduce it.

@JackAdams
Copy link
Contributor

@msavin -- again, I'm pretty sure it's not the editable-json package that's causing this. It's possibly a conflict between the u2622:persistent-session and gwendall:meteor-session-json packages (the editable-json depends on the second package). There's probably another package involved though, as I have both the above packages in a test app and no issues.

@msavin
Copy link
Owner

msavin commented May 1, 2015

@MichelFloyd What I can recommend for now is installing the package manually and removing the editable JSON dependency. You may also have to set the hideInlineEditing helper to true. I'll look for a sturdier resolve in the future.

@MichelFloyd
Copy link
Author

Thanks Max, I’ll give it a shot!

Congrats on quickly becoming one of the most popular packages for Meteor! Nice work!

On May 1, 2015, at 10:44 AM, Max Savin notifications@github.com wrote:

@MichelFloyd What I can recommend for now is installing the package manually and removing the editable JSON dependency. You may also have to set the hideInlineEditing helper to true. I'll look for a sturdier resolve in the future.


Reply to this email directly or view it on GitHub.

@msavin
Copy link
Owner

msavin commented May 2, 2015

@JackAdams I understand that, but I don't understand why we need that package for Editable-JSON to work. It seems like it would be better to go without it for the sake of being leaner and preventing conflicts.

@MichelFloyd Thanks man!

@msavin
Copy link
Owner

msavin commented Jun 2, 2015

Closing this as it is technically not Mongol related

@msavin msavin closed this as completed Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants