Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

outputDirectory lost on reload (override non functional) #144

Closed
ensemblebd opened this issue Feb 7, 2020 · 6 comments
Closed

outputDirectory lost on reload (override non functional) #144

ensemblebd opened this issue Feb 7, 2020 · 6 comments
Labels
bug Confirmed bug released Issue is resolved in a current release
Projects
Milestone

Comments

@ensemblebd
Copy link

ensemblebd commented Feb 7, 2020

Not sure if it's just me. I'll check on a separate PC tonight to verify and report back.
But on latest version from nuget I'm no longer able to override the default directory.

Sequence is as follows:

  1. In the .efmodel designer -> click on any entity
  2. Choose a path from the dropdown in [outputDirectory] property
  3. Save the .efmodel
  4. Notice the file does not exist where specified
  5. Check the still open .efmodel designer, and property is there as you had it.
  6. Close the designer.
  7. Edit the .efmodel in raw text editor, property "outputDirectory=" is present and valid.
  8. reopen the designer.
  9. Property has suddenly disappeared from table, and the .efmodel raw text reflects the lack of property.

It seems reloading the efmodel causes the outputDirectory property to be physically deleted from the table's serialized properties in xml. And the save operation does not produce the file properly.
Furthermore the xml file indicates a isOutputDirectoryTracking value of false, which based on source code grep scan for assignment, appears to indicate that the string value is NULL during serialization. Which may explain why it's dropped when deserialized back to C#.
Guessing here, but not sure why it would be null, and yet present in the xml serialized output?

Anyone else experiencing this as well by chance?

Edit:
Can confirm:

  • happens on multiple environments
  • fresh install win 10 and vstudio 2019 enterprise & latest version(1.3.0.12)
  • Recreated efmodel from scratch to confirm

Doesn't appear to be asymptomatic, but not sure what's wrong. Let me know any thoughts, and thank you!!! This product makes a major difference in the projects my team works on

@msawczyn
Copy link
Owner

msawczyn commented Feb 8, 2020

Glad to hear I can make a contribution to you and your team's lives being a little easier. But regarding what you're seeing ... hard to say. What you describe (and you've dug deeper than I normally hope for in a problem report) shouldn't be able to happen.

If you get a moment, you might try 2.0RC1 to see if it exhibits the same behavior. Note that, as of this release, it won't work with VS2017 so, if that's your environment, it won't be something that will help. I have yet to update the docs, so the new features aren't fully described, but they're pretty self-explanatory and listed in the changelog in the main readme both here and on the Marketplace.

@msawczyn msawczyn added the investigating Looking into this label Feb 8, 2020
@msawczyn
Copy link
Owner

I'm going to take it from the thumbs-up that the 2.0RC1 release worked for you. Unless I hear otherwise, I'll close this within the next day.

@msawczyn msawczyn added pending release Issue is resolved in the current codebase, will be published with the next release and removed investigating Looking into this labels Feb 17, 2020
@ensemblebd
Copy link
Author

can confirm:

  • new version 2.0RC1 did not resolve (however the new changes look awesome btw)
  • Run as admin vs not - no change
  • Removed all extensions - no change
  • Installed community edition vstudio 2019 - no change
  • Tried with brand new .efmodel on 2.0RC1 with all above considered (fresh outside windows o/s), & no change

However since it's only me, I have to assume it's environmental.
I certainly don't see why you'd want to keep this open, I vote close.
But I'll respond back here if I do end up discovering the cause later on - it's fairly inconsequential overall. Thank you!

@RCTycooner
Copy link

Have the is same issue when (I think) one of our devs updated from 1.3.0.11 to 1.3.0.12. The outputdirectory field is suddenly empty, all generated files have been moved to default directory as specified in the efmodel file.

When using 1.3.0.12 myself, if I fill in the OutputDirectory for an entity and let it generate the code, no change, the file is still in the default directory...

Working on VS2019 Enterprise edition, v16.4.4. Using a .NET Core 3.0 project.

@msawczyn msawczyn reopened this Feb 18, 2020
@msawczyn
Copy link
Owner

Thank you both; I've got a bead on this one and it'll be fixed in the upcoming release. I owe you a beer!

@msawczyn msawczyn added bug Confirmed bug and removed pending release Issue is resolved in the current codebase, will be published with the next release labels Feb 18, 2020
@msawczyn msawczyn added this to Enhancement Requests in EFDesigner via automation Feb 18, 2020
@msawczyn msawczyn moved this from Enhancement Requests to Bug Reports in EFDesigner Feb 18, 2020
@msawczyn msawczyn added the pending release Issue is resolved in the current codebase, will be published with the next release label Feb 20, 2020
@msawczyn msawczyn added this to the 2.0.0.0 milestone Feb 20, 2020
@msawczyn msawczyn moved this from Bug Reports to Active in EFDesigner Feb 20, 2020
@msawczyn msawczyn moved this from Active to Done in EFDesigner Feb 20, 2020
@msawczyn msawczyn modified the milestones: 2.0.0.0, 2.0.0 Mar 27, 2020
@msawczyn msawczyn added released Issue is resolved in a current release and removed pending release Issue is resolved in the current codebase, will be published with the next release labels Apr 11, 2020
@ensemblebd
Copy link
Author

<3
So excited, thank you!!!
Hope you are keeping safe in all this craziness. Thank you again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug released Issue is resolved in a current release
Projects
EFDesigner
  
Done
Development

No branches or pull requests

3 participants