Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Support for Empty / blank "File Name Marker" #149

Closed
npagare opened this issue Feb 15, 2020 · 2 comments
Closed

Support for Empty / blank "File Name Marker" #149

npagare opened this issue Feb 15, 2020 · 2 comments
Labels
bug Confirmed bug released Issue is resolved in a current release
Projects
Milestone

Comments

@npagare
Copy link

npagare commented Feb 15, 2020

Hi Michael, how are you ?

When I set File Name Marker to empty, the generated entity file name is having two dots in between file name and "cs". So e.g. for the entity Person the generated .cs file name is Person..cs which I was expecting to be Person.cs . Is this by design ? If so, can you help us to remove that empty node in the file name ? I would appreciate that.

Thank you.

@msawczyn msawczyn added the bug Confirmed bug label Feb 17, 2020
@msawczyn msawczyn added this to Enhancement Requests in EFDesigner via automation Feb 17, 2020
@msawczyn msawczyn moved this from Enhancement Requests to Bug Reports in EFDesigner Feb 17, 2020
@msawczyn
Copy link
Owner

Whoops! Thanks for the catch. That fix is in and will be out in the next release.

You should note that, depending on your workflow, there may be repercussions to not having a marker word in the generated code's file name. Not only is it less clear to the humans, source control systems and linters that this is generated code (so can be safely ignored), but there's a bit of logic in the T4s that does cleanup of dead files, and it wants to use the marker word to determine if the file was generated by the modeler or not. Haven't dug into what will happen with a blank marker, but wanted to throw that out there for you.

@msawczyn msawczyn added the pending release Issue is resolved in the current codebase, will be published with the next release label Feb 17, 2020
@msawczyn msawczyn added this to the 2.0.0.0 milestone Feb 17, 2020
@npagare
Copy link
Author

npagare commented Feb 17, 2020

Thanks Michael.

How about having a default marker folder say ''generated' that could be renamed via properties panel. It will create namespace with that node for generated classes. There could be separate default folders for entities, enums, structs under the folder 'generated'.

The default path of the 'generated' folder can be under the root folder where .efmodel is stored - but could customized in properties window if developer want to spool generated code in a separate class library.

I also see that in the generated folder - code older or deleted entities from .efmodel diagram is not deleted. May I know if this is by design ? It will be really helpful to autodelete those files. I have been deleting manually before saving .efmodel to generate a fresh batch. Thoughts ?

Thank you.

@msawczyn msawczyn moved this from Bug Reports to Active in EFDesigner Feb 20, 2020
@msawczyn msawczyn moved this from Active to Done in EFDesigner Feb 20, 2020
@msawczyn msawczyn modified the milestones: 2.0.0.0, 2.0.0 Mar 27, 2020
@msawczyn msawczyn added released Issue is resolved in a current release and removed pending release Issue is resolved in the current codebase, will be published with the next release labels Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug released Issue is resolved in a current release
Projects
EFDesigner
  
Done
Development

No branches or pull requests

2 participants