Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 404 from not found strings #4

Closed
mo-ah-dawood opened this issue May 11, 2020 · 1 comment
Closed

remove 404 from not found strings #4

mo-ah-dawood opened this issue May 11, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mo-ah-dawood
Copy link
Contributor

at first this package is very good,

please remove 404 from the string if the key is not found

Why

in some cases i forgot to set the key in my json file so i need to use the default one
The good advantage for removing it is to allow us use a default strings may be just make one json file for Arabic and leave the English use the default strings
note that the keys may be readable strings
like this
"Withdraw profits": "سحب الأرباح"
now if the language is arabic the right side will be used
else the left will be used

@msayed-net msayed-net added the enhancement New feature or request label May 11, 2020
@msayed-net msayed-net self-assigned this May 11, 2020
@msayed-net
Copy link
Owner

Thanks for reaching out to me

Your suggestion considered and implemented in v2.0.10

Do not hesitate contacting me with any further enhancement suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants