Create Directory before save file #29

metd · 2014-02-13T09:35:04Z

I want to create my own DIR.
I used mkdirp it saved file but file size is 0 byte
What should I do?

busboy.on('file', function(fieldname, file, filename, encoding, mimetype) {
            var saveTo = '/uploads/date/time/file.jpg';
        mkdirp(saveTo, function(err) {
        if (err) {
            console.error(err);
        } else {
            console.log('Save File..');
            file.pipe(fs.createWriteStream(saveTo));
        }
    });
});

The text was updated successfully, but these errors were encountered:

mscdex · 2014-02-13T14:52:00Z

What node version are you using?

metd · 2014-02-13T15:40:53Z

node v0.10.16
expressjs 3.4.4
connect-busboy 0.0.1

may be problem is about synchronous or asynchronous,
when i use mkdirp in synchronous mode, it's work fine.
problem happened when i switch to asynchronous mode

This is my code.

var express = require('express');
var http = require('http');
var busboy = require('connect-busboy');
var fs = require('fs');
var mkdirp = require('mkdirp');
var path = require('path');
var inspect = require('util').inspect;

var app = express();

app.use(
    busboy(
    {
        limits : {
            fileSize : 10 * 1024 * 1024
        }
    }
));

app.get('/upload', function(req, res, next){
    res.send('<html><head></head><body>\
            <form method="POST" enctype="multipart/form-data">\
             <input type="text" name="textfield"><br />\
             <input type="file" name="filefield"><br />\
             <input type="submit">\
           </form>\
         </body></html>');
});

app.post('/upload', function(req, res, next){
    req.busboy.on('file', function(fieldname, file, filename, encoding, mimetype) {
        console.log('File [' + fieldname +']: filename: ' + filename + ', encoding: ' + encoding);

        var rootDir = path.dirname(require.main.filename);
        var uploadDir = 'media/photos';
        var saveTo = path.join(rootDir, uploadDir);

        mkdirp(saveTo, function(err) {
            if (err) {
                console.error(err);
                return next(err);
            } else {
                console.log('Save File..');
                saveTo = path.join(saveTo, path.basename(filename));
                file.pipe(fs.createWriteStream(saveTo));
            }
        });

        file.on('data', function(data) {
            console.log('File [' + fieldname + '] got ' + data.length
                    + ' bytes');
        });
        file.on('end', function() {
            console.log('File [' + fieldname + '] Finished');
        });

    });

    req.busboy.on('field', function(fieldname, val, valTruncated, keyTruncated) {
        console.log('Field [' + fieldname + ']: value: ' + inspect(val));
    });

    req.busboy.on('end', function() {
        console.log('Done parsing form!');
        res.send(200, 'OK');
    });

    req.pipe(req.busboy);
});


http.createServer(app).listen(4000);

mscdex · 2014-02-13T16:37:34Z

I see the problem: you've added a 'data' handler right after you called the async mkdirp. This causes data to be released immediately. Remove that and you should be fine.

metd · 2014-02-13T16:41:51Z

Brian White
Thank you so much.

metd closed this as completed Feb 13, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Directory before save file #29

Create Directory before save file #29

metd commented Feb 13, 2014

mscdex commented Feb 13, 2014

metd commented Feb 13, 2014

mscdex commented Feb 13, 2014

metd commented Feb 13, 2014

Create Directory before save file #29

Create Directory before save file #29

Comments

metd commented Feb 13, 2014

mscdex commented Feb 13, 2014

metd commented Feb 13, 2014

This is my code.

mscdex commented Feb 13, 2014

metd commented Feb 13, 2014