dicer writable never ends if bad multipart

[golyshevd]

stream.pipe(dicer); never fired dicer 'end' event if broken multipart passed.

I had to write this code to solve the problem

stream.on('data', function (chunk) {
    dicer.write(chunk);
});

dicer.on('end', function () {
    dicer.__ended__ = true;
   //  ok
});

stream.on('end', function () {
    dicer.end();
    if ( dicer.__ended__ ) {
        return;  
    }

    // ERROR
});

I expected SyntaxError or another on 'error' dicer event

[mscdex]

Ok, this should be fixed in the master branch -- an error event will be emitted. Note that I've also changed the 'end' event for Dicer to 'finish' to keep in line with the documented events for a Writable stream.

[golyshevd]

Thank you! It works! And another similar issue. If Readable stream emits an error, I expect that dicer Writable will stop parsing and emit this error on themself instance and should not emit 'finish' if any 'error' event emitted

[mscdex]

@golyshevd I looked at Writable's code in node core while I was working on this and from what I can tell 'finish' is still emitted even when 'error' is emitted. So I was trying to keep that same behavior.

[golyshevd]

hm, surprising, anyway, thanks!