Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default charset: latin-1? #173

Open
bneutra opened this issue Mar 7, 2017 · 1 comment
Open

default charset: latin-1? #173

bneutra opened this issue Mar 7, 2017 · 1 comment

Comments

@bneutra
Copy link

bneutra commented Mar 7, 2017

I'm finally upgrading from 0.1.21 (!) to 0.2.6. It appears to me that the default charset (when creating New Client) changed (from utf-8 to, not sure, latin-1?) I noticed in the 0.1.22 README.md it says the default charset is utf-8, then later the documentation doesn't specify what the default is.

Honestly, I'm good (I just added charset: 'utf-8' to the connection options) But I ended not being able to figure out how it every worked for me on 0.1.21 (i.e. how the charset option propagates through the code to the c code). And I thought I'd just let you know and encourage you to document the default behavior in the README.md, so other's don't get burned by assuming stuff.

@antishov
Copy link

antishov commented Mar 8, 2017

it looks like you are right. I am fixed it with "charset: 'utf 8'" in the constructor config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants