Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty header in default response causing parsing errors #31

Closed
avocade opened this issue Feb 6, 2017 · 3 comments
Closed

Empty header in default response causing parsing errors #31

avocade opened this issue Feb 6, 2017 · 3 comments

Comments

@avocade
Copy link

avocade commented Feb 6, 2017

As a somewhwat related issue to 29, we're getting an empty access-control-expose-headers: – with a CR immediately after the colon – on all our requests when using plug CORSPlug (regardless of setting origin: or not. This caused an internal http parsing lib written in C to bork out which took a while to debug… 💯

Non-null/emptystring return values for headers is not recommended if we want to make life easier for http parsers :)

Note: we're not using Phoenix, just a plain elixir app with plugs.

@mschae
Copy link
Owner

mschae commented Jul 15, 2017

Hey @avocade is this still an issue? I believe we changed this behaviour to use null instead.

@mschae
Copy link
Owner

mschae commented Jul 15, 2017

(Just released 1.4.0 because we introduced a new header that might be null (Vary) which is now fixed.)

@avocade
Copy link
Author

avocade commented Jul 16, 2017

On vacation, will be a while before I can verify this :) So I'll say it's closed for now.

@avocade avocade closed this as completed Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants