Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to reset repair cost #20

Closed
dull4h4n opened this issue Feb 1, 2022 · 4 comments
Closed

Add a way to reset repair cost #20

dull4h4n opened this issue Feb 1, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@dull4h4n
Copy link

dull4h4n commented Feb 1, 2022

I mentioned this to you in a comment on curse a while back. I just wondered if you had given it any further thought.

The suggestion is to be able to take a book that combined multiple enchants, like when combining 4 Protection II books to make a single Protection IV. It has an NBT 2 tag which makes it very expensive. The idea is to be able to put that NBT2 version of Prot IV and then grind the enchant and create a fresh NBT1 Prot IV that isn't as expensive to use.

@dull4h4n dull4h4n changed the title Suggestion: way to remove nbt tags on single enchant combined books Suggestion: way to remove nbt tags on single enchant from combined books Feb 1, 2022
@mschae23
Copy link
Owner

mschae23 commented Feb 1, 2022

Sure, I could implement that. How should this be done? Just putting in the enchanted book doesn't work for this, as that is already used for removing the enchantments in vanilla. Maybe by adding an additional empty book?
Also, should this work for tools and armor as well?

Anyway, I think this would probably be disabled by default though, as it isn't a very intuitive feature.

@dull4h4n
Copy link
Author

dull4h4n commented Feb 3, 2022

Its just putting a book into grinder under an enchanted book. This is how it worked with the old 1.12 disenchanting mod from years ago. I think most people who used disenchanters would be familiar with the ability to remove the NBT and huge cost with manually enchanted books.

@dull4h4n
Copy link
Author

dull4h4n commented Feb 3, 2022

Not sure why it would need to be disabled by default, it wouldn't affect anyone who was not familiar with putting a book in grinder under another book (rather than an item). There would be no other reason to do that.

@mschae23 mschae23 added the enhancement New feature or request label Apr 13, 2022
@mschae23 mschae23 changed the title Suggestion: way to remove nbt tags on single enchant from combined books Add a way to reset repair cost Apr 24, 2024
@mschae23
Copy link
Owner

I've added this new functionality to the mod now (although yes, sorry, disabled by default).

Its just putting a book into grinder under an enchanted book.

This wouldn't work here, because that combination of items is already used by the "moving enchantments between books" feature. Instead, I've now made it so you have to put a diamond into the bottom slot instead, but that is configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants