Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow branch selection #3

Closed
maaaaarco opened this issue Jul 4, 2019 · 3 comments
Closed

Allow branch selection #3

maaaaarco opened this issue Jul 4, 2019 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request to be implemented

Comments

@maaaaarco
Copy link
Collaborator

Currently the script is comparing the selected Permission Set or Profile against the version on the master branch. Allow users to select the branch to compare.

Desired solution
After the selection of Profile or Permission Set present a list of possible branches. master should be the default.
@maaaaarco maaaaarco added the enhancement New feature or request label Jul 4, 2019
@mschmidtkorth mschmidtkorth added documentation Improvements or additions to documentation to be implemented and removed documentation Improvements or additions to documentation labels Jul 5, 2019
@mschmidtkorth
Copy link
Owner

Agree, comparing against master will be the most likely but not the only scenario.

@maaaaarco
Copy link
Collaborator Author

Maybe we can provide two commands, one to compare against the master and another one that allows you to select the other branch.

  • Compare Permissions
  • Compare Permissions with branch...

@mschmidtkorth
Copy link
Owner

mschmidtkorth commented Jul 5, 2019 •
edited
Loading

Yes, we could also add an alternative command (opt) so we don't need to duplicate them. But might not be ideal from a UX perspective. For now I've implemented a simple selection via a96d743. Feel free to add a default!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request to be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maaaaarco @mschmidtkorth