Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to parse ibanity-java-1.1.20180605145337 #1

Open
FauxFaux opened this issue Jan 18, 2019 · 2 comments
Open

Fails to parse ibanity-java-1.1.20180605145337 #1

FauxFaux opened this issue Jan 18, 2019 · 2 comments

Comments

@FauxFaux
Copy link

Maven3ArtifactVersion::new("ibanity-java-1.1.20180605145337") panics, as that date does not fit in an integer. This version actually exists in maven central.

(I plan to fix this and publish a fork of the library on crates.io, unless you object?)

@FauxFaux
Copy link
Author

My plan to test against upstream's implementation has gone.. a bit wrong. https://issues.apache.org/jira/browse/MNG-6568

@mschorsch
Copy link
Owner

mschorsch commented Jan 19, 2019

Hi @FauxFaux. Sorry for the delay.
I am glad that someone is interested in developing this library further. As you probably saw, the last commit is 2 years ago. I like to accept pull requests. Alternatively, you can also fork the library. As you wish.

Some hints:

  • The library could be made more efficient by reducing heap allocations.
  • This is a direct translation of Java code from 2 years ago. Maybe there have been changes in maven.
  • The library could be made a bit more ergonomic today (eg 3.1..5-SNAPSHOT" .to_maven_version())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants