Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem for two subdomains separated by dot with --subdomain-file #17

Closed
johanmazel opened this issue Aug 18, 2016 · 3 comments
Closed

Comments

@johanmazel
Copy link

johanmazel commented Aug 18, 2016

When I use --subdomain-file with subdomains each composed of two subdomains separated by a dot (e.g. "toto.tata"), I do not get an answer.
By putting some print inside fierce, I found that the problem comes from this line : "result = dns.name.Name(tuple(subdomains) + domain.labels)".
It replaces dots in subdomains by ".".
For example, the subdomain "toto.tata" becomes "toto.tata" which causes the DNS request to fail.

Is this an expected behavior ?
Am I not supposed to use the --subdomain-file option with this kind of input?

@mschwager
Copy link
Owner

I think this may be related to #12. I'll take a look. Thanks for the heads up!

@johanmazel
Copy link
Author

johanmazel commented Aug 25, 2016

I do not think it is related to #12.

Sorry, I actually made a formatting mistake.

I meant:
"It replaces dots (".") in subdomains by ".".
For example, the subdomain "toto.tata" becomes "toto.tata" which causes the DNS request to fail."

@mschwager
Copy link
Owner

Hey @johanmazel! I believe 27bed0c should fix your issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants