Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide full context for the HttpRequestException #19

Open
doggy8088 opened this issue Mar 28, 2024 · 6 comments
Open

Provide full context for the HttpRequestException #19

doggy8088 opened this issue Mar 28, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@doggy8088
Copy link
Contributor

I wish there is an original response JSON content comes from the API response when there is an HttpRequestException thrown. This is for better debugging.

@jochenkirstaetter jochenkirstaetter added the enhancement New feature or request label Mar 28, 2024
@jochenkirstaetter
Copy link
Contributor

Good suggestion, @doggy8088

That's coming with the improvements regarding logging.
Give me a bit of time to work this out.

@doggy8088
Copy link
Contributor Author

Before logging been implemented, I think the exception issue might be able to improve at first.

@jochenkirstaetter
Copy link
Contributor

Yes, agreed.
Now, that the Gemini API is fully implemented by the library, I'm looking into further improvements and stabilization.

@doggy8088
Copy link
Contributor Author

Is it possible add an "InnerException" when throwing exception at Gemini API call failed?

@sebastianbk
Copy link

Is it possible add an "InnerException" when throwing exception at Gemini API call failed?

I would really appreciate this as well.

@jochenkirstaetter
Copy link
Contributor

Hi @doggy8088 and @sebastianbk

The code does not catch and rethrow those exceptions, those are straight from the HttpClient. I'll see what I can do to improve the situation though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants