-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MDL Dialog #44
Comments
+1, it's must have feature :) |
+1. I really need the Dialog for my project... |
Are there already plans to implement this feature or design thoughts? I started with a very basic implementation which you can find here: http://plnkr.co/edit/okxSWbE7JdFNzoNSaTuS?p=preview I am using a directive to attach it to the dialog tag(placed within body which is requirement by the polyfill I used) and a singleton service to show/hide a component within a dialog. Issues I came accross:
The solution does not feel 100% right to me but it works. |
Hi, thx for your work! There are plans for the dialog but i didn't start working on it. Also there is no design document but some requirements i have in mind (don't know if they all are feasible):
I'm always happy to include pull requests. They don't need to be perfect but well tested. we can mark the DialogService as @experimental and play around a little bit with the dialogService and see what other users think about our solution! |
+1 Why is this feature missing? |
will be part of the next release. already in the master... |
No description provided.
The text was updated successfully, but these errors were encountered: