Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you compared it with the official TF implementation? #11

Closed
Vermeille opened this issue Apr 30, 2019 · 7 comments
Closed

Have you compared it with the official TF implementation? #11

Vermeille opened this issue Apr 30, 2019 · 7 comments

Comments

@Vermeille
Copy link

Hi,
Have you compared it with the official TF implementation? Are the score significantly different? Are there pitfalls one should be about when using it that might get significantly different results than TF?

Thanks, and thank you for writing that code.

@mseitzer
Copy link
Owner

Hi,
I am actually in the process of comparing it with TF's implementation, and I will update with more info once I get around to do so.

Unfortunately, so far I have got pretty different results between this and TF's version. At the moment, I would not recommend using the results from this implementation for anything serious. I am currently digging into where the differences stem from.

@Vermeille
Copy link
Author

Thank you for your answer :)

@mseitzer
Copy link
Owner

Hey,
after some long detective work I found several sources of errors between the TF and Pytorch implementation. It turns out that the Inception model of Pytorch uses different weights and a slightly different model than Tensorflow's Inception. This introduced a significant source of error. I pushed an updated version of the model (see #16), which fixes those errors.

The model itself now computes the same results as the TF model when inputting the exact same image. There might be other sources of error (e.g. image interpolation) which could result in the FID score still being slightly different. However, I think the results should now be pretty comparable.

@Vermeille
Copy link
Author

Thank you SO MUCH.

You're making my life so much easier with that!

Kudos to you for your excellent work!

@mseitzer
Copy link
Owner

You're welcome. Out of interest, what you are doing that is so much easier with Pytorch than Tensorflow?

@Vermeille
Copy link
Author

You're preventing me from installing TF, which messes with my CUDA version on some of my systems and doesn't play nicely with pytorch.

You're basically making my life easier and preventing me some sysadmin pain.

@mseitzer
Copy link
Owner

mseitzer commented Jun 3, 2019

I see. Yeah, CUDA and Tensorflow is a mess.

@mseitzer mseitzer closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants