Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of Request_BUFFEROVERRUN assignment #7

Open
msftrncs opened this issue Mar 19, 2022 · 1 comment
Open

Optimization of Request_BUFFEROVERRUN assignment #7

msftrncs opened this issue Mar 19, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@msftrncs
Copy link
Owner

IF i <> CMD_N OR CANSDO_DATA[0].0 THEN
(* either ran out of buffer or segmented transfer is complete *)
ActXfr_Dn := FALSE;
Request_BUFFEROVERRUN := i <> CMD_N;

The assignment of Request_BUFFEROVERRUN (line 120) should be moved before line 117, and then its result utilized in the IF's condition.

@msftrncs msftrncs added the enhancement New feature or request label Mar 19, 2022
@msftrncs msftrncs self-assigned this Mar 19, 2022
@msftrncs
Copy link
Owner Author

Note that the detection of the buffer overrun condition is unaware if the original request was of a known length, if it was of an unknown length, and this happens to be the last segment, then flagging the buffer overrun may not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant