Packing Andrei's Upcoming rcstring

[nordlow]

I'm having problem packing Andreis' prel implementation of rcstring at https://github.com/nordlow/justd/blob/master/rcstring.d with pack.

What's the preferred way of doing this if I can't modify the original implementation, which I won't be able to do when this become standardized?

I've tried

import std.stdio;
import std.conv: to;
import rcstring;
import msgpack;

void rcstringPackHandler(ref Packer p, ref RCString rcstring)
{
    writeln("Packing ", p);
    p.pack(rcstring.toString);
}

unittest
{
    registerPackHandler!(RCString, rcstringPackHandler);
    writeln(RCString("").pack);
}

which gives

[149, 149, 192, 192, 0, 183, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 183, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 147, 0, 0, 0]

which isn't what I want. For some reason my rcstringPackHandler is ignored.

I want this to equal string packing, namely

[192]

[repeatedly]

Ah... the problem is type mismatch.

msgpack-d/src/msgpack.d

Line 854 in 3b7948e

if (auto handler = typeid(T) in packHandlers) {

Maybe, we should use typeid(Unqual!T) instead of typeid(T).
Could you check typeid(Unqual!T) version with your case to check work or not?

[nordlow]

Works! Do you change?

[repeatedly]

I pushed changes to master and added v0.9.3 tag.

[nordlow]

Thanks!