-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataView usage overhead #37
Comments
btw, in browsers msgpack-javascript now beats notepack.io :) |
Actually we have 10-20 MB of compressed payloads, real size few times bigger 😄 |
Does DataView have such overhead? I have read https://v8.dev/blog/dataview and in fact, DataView seems fast enough for NodeJS v12. BTW My use cases are browsers, too. So I am focusing on browsers for now. Any optimizations are really welcome, though. |
Take a look at this test https://jsperf.com/dataview-vs-typed-array-views I've tried to remove DateView partially from this project and use typed array approach for numbers decoding and it gave me a little bit more performance, but it's not ready for full testing yet. Float/Int64/Uint64 is not done yet. |
I think t https://jsperf.com/dataview-vs-typed-array-views does not fare because of https://jsperf.com/dataview-vs-typed-array-views/28 seems more accurate and it suggests DataView is the fastest. What do you think about it? |
yeah, these tests are not perfect. I need we need more investigation in this area. |
I've tried https://github.com/finscn/fast-dataview and their perf tests gives me next in nodejs env:
|
Sounds an interesting idea. If the backend of DataView becomes faster, even if and only if on NodeJS, it is a kind of free lunch! BTW I have released v1.2.2: v1.2.1...v1.2.2 |
Thanks, Good night :) |
Thanks for making this a better library @gfx ! |
hi @gfx have you considered using direct buffer instead of DataView? DataView performance is still not optimal in many cases. I know it will require additional work on number decoding but it can give performance boost.
I hope I am not too annoying with performance stuff :) We have project with huge msgpack payloads (up to 10-20 MB) that we need to parse in browsers.
The text was updated successfully, but these errors were encountered: