Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deprecate msgpack-python on pypi #493

Closed
mbway opened this issue Dec 13, 2021 · 4 comments
Closed

Fully deprecate msgpack-python on pypi #493

mbway opened this issue Dec 13, 2021 · 4 comments

Comments

@mbway
Copy link

mbway commented Dec 13, 2021

I recently switched my requirements file from using conda to pip/pypi and accidentally missed that the package has a different name (just msgpack) on pypi. In conda-forge the name of the package is still msgpack-python. This led to a different behaviour (unpacking into bytes rather than str by default) which was confusing.

edit: I was confused and hadn't actually checked the pypi page for msgpack-python specifically (which has no description other than to say the package is deprecated), only the msgpack one which refers to msgpack-python being deprecated. It is still confusing when moving from conda-forge to pypi though. Some warning printed during installation or at import might be useful?

@methane
Copy link
Member

methane commented Dec 15, 2021

Actually, that's what I did when I renamed from msgpack-python to msgpack.

See this comment for why I stopped using dummy transition package.
#266 (comment)

@methane
Copy link
Member

methane commented Dec 15, 2021

And upstream issue is not closed yet.
pypa/pip#4961

So pip may not support such transitional package.

@mbway
Copy link
Author

mbway commented Dec 15, 2021

would it break things if warnings were added in the meantime until pip is fixed? also with the recent release of pip getting a new resolver (pypa/pip#988) it's possible that the issue is fixed?

@methane
Copy link
Member

methane commented Dec 23, 2021

AFAIK, warning is not shown during pip install.

@methane methane closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants