Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong MpPortableUtil subclass selected on Pharo 11 #19

Closed
tatut opened this issue Feb 1, 2024 · 3 comments
Closed

Wrong MpPortableUtil subclass selected on Pharo 11 #19

tatut opened this issue Feb 1, 2024 · 3 comments

Comments

@tatut
Copy link

tatut commented Feb 1, 2024

MpPortableUtil selects MpSqPortableUtil when initializing on Pharo. (DialectSpecificClass := self subclasses at: 1)

If I set it manually to MpPhPortableUtil and send invoke, it works after that.

@mumez
Copy link
Member

mumez commented Feb 2, 2024

Thanks for the feedback.
Normally if you install MesssagePack via Metacello, the correct DialectSpecificClass (MpPhPortableUtil) should be set. BaselineOfMessagePack >> preLoadForPharo does the trick.

BaselineOfMessagePack >> preLoadForPharo
	Smalltalk globals at: #MpPhPortableUtil ifPresent: [ :cls | cls initialize].

But in Pharo 11, the method seems not to be called automatically. I'll investigate the issue.

@mumez
Copy link
Member

mumez commented Feb 4, 2024

Now the error was fixed in develop branch: https://github.com/msgpack/msgpack-smalltalk/tree/develop
Please confirm it. I'll close the issue after a while.

@mumez mumez mentioned this issue Feb 4, 2024
@tatut
Copy link
Author

tatut commented Feb 5, 2024

Can confirm. The examples in README work when installing from develop branch to a fresh P11 image.

@mumez mumez closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants