call os.fsync() following flush()

[parkerduckworth]

In tinydb/storages.py, line 112, a call to self._handle.flush() is made, in the write() method inside the class JSONStorage:

    def write(self, data):
        self._handle.seek(0)
        serialized = json.dumps(data, **self.kwargs)
        self._handle.write(serialized)
        self._handle.flush()
        self._handle.truncate()

Is the goal of this call to flush to ensure all internal buffers associated with self._handle are written to disk?

If so, it may be a good idea to make a call to os.fsync() to ensure this behavior.
ref: Python Docs

I have already implemented this change in my fork. If this is the case, I will create a PR.

[msiemens]

Yes, as far as I can remember, that's the intent. I'm always glad to accept PRs 🙂

[parkerduckworth]

Cool. Will create one now.

[msiemens]

Closed in #212, which also is released now 🙃