Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] remove unnecessary dist file from svelecte #148

Closed
LeoDog896 opened this issue Jan 26, 2023 · 3 comments
Closed

[Refactoring] remove unnecessary dist file from svelecte #148

LeoDog896 opened this issue Jan 26, 2023 · 3 comments

Comments

@LeoDog896
Copy link

Currently, the dist folder is in the repository. Is it a better idea (for the sake of contributions) to remove it? (If GitHub pages depends on it, it's better to use a GitHub deployment action instead).

@mskocik
Copy link
Owner

mskocik commented Jan 29, 2023

Is it a better idea (for the sake of contributions) to remove it?

Not really. I like to have it here, when I need iife version for some project.

@mskocik mskocik closed this as completed Jan 29, 2023
@LeoDog896
Copy link
Author

Wouldn't this make it annoying to resolve merge conflicts related to submitted PRs that modify source code? (Also, you can probably just publish the IIFE version to npm and use unpkg there rather than in the source control)

@mskocik
Copy link
Owner

mskocik commented Jan 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants