New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make documentation great #22
Comments
I found it hard to understand the meaning of different parts of the application and how they fit together. Some aspects are relatively familiar from factories but on the store side I found it hard to follow. Maybe we can find a metaphor from the real world to make it easier to understand. At least that's usually what helps me and what I used in the Relm4 book (for example in chapter 1). |
@AaronErhardt I've updated the application architecture chapter in the book by adding "How does it fit into my relm4 application" section. Can you check it? PR #36 |
I like it. But isn't a store view rather something like this in database analogy? SELECT FROM data_store WHERE changed=true; |
No it's not.
would mean that we only show values which were updated. In pseudocode view is something like this:
|
Ok, thanks for clarifying. If I'm correct the store view does two things then:
Maybe something like this could be put into the book for each part. Just bullet points of what a part is responsible for. And I just remembered that I had problems to understand the graph of the relm4-store architecture. Maybe it's better to make a graph without the regular update function that only focuses on relm4-store. Otherwise the arrows are a bit confusing. And it should be obvious that you can still use the normal Relm4 architecture for the rest of the application. Or actually, you only need to adjust the first graph that shows the Relm4 architecture. Just move all components to the same place as in the second graph so it's clear that the second graph is an extension of the first one. |
I've released new prerelease version of the book under https://mskorkowski.github.io/relm4-store/prerelease/book/index.html It contains updated mvc diagram for relm4 Also in @AaronErhardt when you have a bit of the time can you check and tell me what you think about that? ExtrasI've also started working on the Prerelease version of the book is because I found a few bugs in the |
Feels much better to read for me. Well done! I also like the idea of the There's one thing I noticed (I hope I can have a closer look this weekend): |
In Relm4/Relm4#46 (comment) @AaronErhardt rised an issue with documentation being hard to understand
Let's keep the discussion here
The text was updated successfully, but these errors were encountered: