Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for docker should include details about using --init #96

Open
kratsg opened this issue Jul 19, 2023 · 2 comments
Open

Documentation for docker should include details about using --init #96

kratsg opened this issue Jul 19, 2023 · 2 comments
Labels

Comments

@kratsg
Copy link

kratsg commented Jul 19, 2023

See this (old) blog post: https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/ and this solution (https://github.com/krallin/tini) which is now built into docker via --init. The shell scripts run by shell2http will typically become zombie and won't be cleaned up without --init or an init-script in the docker image.

@msoap msoap added the docker label Feb 6, 2024
@msoap
Copy link
Owner

msoap commented Feb 6, 2024

Hi @kratsg, sorry for dalay, I don't see this problem in my docker containers even if they have been running for months and are heavily used.
Could you please provide minimal example like Dockerfile with build/run command and with such issue (and without --init)?

@kratsg
Copy link
Author

kratsg commented Feb 6, 2024

Hi @msoap that's fine -- see this repo which contains the Dockerfile. Nothing very complicated, but we've observed zombie processes not getting cleaned up over time. The solution is to run the docker image with --init which you can't specify as part of the Dockerfile unless you include tini manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants