-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaguar XF S (x260) missing items #10
Comments
Will add in the next couple of days. One thing i was wondering about this is that in the attributes it has a roof opens parameter. Didnt know if this related to whether vehicle has a sunroof or just a drop top. Can you let me know what this attribute is for yours. If it does signify then we can only show this for cars with sunroof. |
if i get attributes i have |
Sorry yes, this is the one. Great, we can use this to determine to show the sunroof open status. Do you think this should be under windows. I think it makes more sense as doors are part of a lock device and can be unlocked from the sensor. |
Yes agree windows is the best place for it. |
Yes, there are other params i have not yet added that show mileage to service. These are already on the list to add. |
Ok, have updated this to 0.2alpha today including: |
Apologies, I really need to work out a better way to test things I don't have on my car. Should work on sunroof now in master branch update. On the DPF, it must be that your car is not reporting this. There should also be additional sensor info on car service info relating to this. It will not show them if they are not presented in the api data. If you want to send me a data output I can look at this to see exactly what your car sends/doesn't send. See update in readme for how to enable data debugging. |
No need to apologize. I can test any think you need if my car allows me to :) Sunroof is now there
|
It looks like there is no DPF or adblue info being sent by your car. Seems there is many differences in what sensors are presented on different cars. Can you help test the dev branch update? See comments in issue #13. Thx |
@jayjaytyper can you let me know if the latest dev version has now fixed all your issues (well the ones that are not JLRs fault! ;-)) |
Yes it dose thank you. can you just update the docs to the correct paramter for distance_units: i keep getting invalid config, i also not have the same sensors for my car 3 times but i think that could just be a problem for me as i was using HACS to track the changes before moving to dev keep up the good work |
Updated readme. Should have been distance_unit. |
@msp1974 about distance we have 5 data. 'ODOMETER_MILES_RESOLUTION': 'false', may is better to use this false/true so HA is not different from car, and have not configuration entry? |
@MZorzy I had seen this but it is not correct. My car is set to miles but these parameters show like yours. Currently, HA is using the HA settings (which I assume will usually be the same as the car), however, HA does not support mix in UK of imperial and metric. The config entry is only to override HA to show miles for distance and metric units for everything else. It originally used the user preference settings in the JLR app but the JLR api frequently did not return these in the response. If you keep making the request it would return 1 in 6 or 8 times which made me think this was not a reliable way either. I think using HA is best and for everybody outside the UK, there is no need to add anything to config.yaml. |
oh, agree. thankyou |
Hello, First of all great work.
In order to help you with missing item i created the list below. that i know the status are there if i run the jlrpy.py manually (just never had the knowledge to its this working in HA)
Sunroof - Status {'key': 'IS_SUNROOF_OPEN', 'value': 'FALSE'}
FYI
The DPF is not there on the API even tho i have the Diesel
Happy to help with any testing if required
The text was updated successfully, but these errors were encountered: