Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailto near user profiles hyperlinks #99

Closed
4 of 7 tasks
fabiodrg opened this issue Mar 11, 2022 · 4 comments · Fixed by #101
Closed
4 of 7 tasks

Add mailto near user profiles hyperlinks #99

fabiodrg opened this issue Mar 11, 2022 · 4 comments · Fixed by #101
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fabiodrg
Copy link
Collaborator

fabiodrg commented Mar 11, 2022

  • Add a "send email" button in each individual FEUP employee hyperlink (e.g. Teacher)
  • Allow to select multiple FEUP employees to send an email

My main motivation for this is when having to contact more than one teacher from search results or from course unit pages. The typical approach is to open the profile in separate pages and copy the links. With batch email I could select multiple users without that manual process. Furthermore, for single recipients, I could click one button near the user name/link without having to move to a different page to get the email.

Tasks

  • Fetch the profile view page for parsing the institutional email (may not be visible). E.g., https://sigarra.up.pt/feup/en/func_geral.formview?p_codigo=<id>. Another possible hyperlink is https://sigarra.up.pt/feup/pt/vld_entidades_geral.entidade_pagina?pct_codigo=<id>. It is commonly used for students, but I have seen it for FEUP staff as well, which then redirects to func_geral.formview. For example, thesis lists.
  • Add the buttons with mailto hyperlinks near the original hyperlink tag, i.e. <a>
  • Add an option on right-side sidebar that enables selecting multiple addresses to send the email? Useful when you want to contact more than one person. Perhaps, open a modal with all emails and enable batch selection
    • One step further: BCC + CC?
  • Cache the emails per user ID
  • Configurable threshold. i.e., if the page has more than E email addresses, then ignore. Might be useful in search results pages with dozens of emails. Default, 15?
  • Ignore hyperlinks for the logged in user?
@fabiodrg fabiodrg added enhancement New feature or request good first issue Good for newcomers labels Mar 11, 2022
@fabiodrg fabiodrg self-assigned this Mar 13, 2022
@fabiodrg fabiodrg changed the title Add mailto for teachers in curricular units pages Add mailto near user profiles hyperlinks Mar 14, 2022
@fabiodrg
Copy link
Collaborator Author

The issue #69 is related. Might be useful to create a Person parser. It should support parsing from the document or from a custom context (e.g. URL, html, DOMParser). That parser could be used in both issues (this one and #69)

@fabiodrg fabiodrg linked a pull request Mar 16, 2022 that will close this issue
@fabiodrg
Copy link
Collaborator Author

fabiodrg commented Mar 17, 2022

One more issue to handle. looks like Sigarra server responses are encoded as text/html; charset=iso-8859-15. As the response body is interpreted as utf-8, weird stuff appears...

image

image

@fabiodrg
Copy link
Collaborator Author

With respect to ignoring hyperlinks associated to the logged in user.. I thought it would be easy, but it looks like the hyperlinks used to access my profile near the login form and on the top bar use yet another ID is not the user ID (student up or staff identifiers)...

I could fetch that URL to gather the actual user ID, just not sure if it is worth it.
image
image

@fabiodrg
Copy link
Collaborator Author

Found a third type of page for users in thesis lists: https://sigarra.up.pt/feup/pt/inst_geral.ver?P_CODIGO=1891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant