Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending support for injecting require, module and exports as dependencies #52

Closed
FransBosuil opened this issue Jul 16, 2018 · 4 comments

Comments

@FransBosuil
Copy link
Contributor

I'm using your plugin to convert my 3th party AMD dependencies. This seems to be working fine for most of the dependencies. However, one of the libraries is 'uglified' and is injecting 'exports' as variable 'a'. As explained in the caveats, the 'exports' dependencies are skipped. So, variable 'a' is not defined which makes the library faulty.

To resolve the issue, I have cloned your repository, created a branch, added some tests and updated the code base. Unfortunately, I'm not authorized to push my branch to your repository. Can you please give me permission to push the branch? This way, you can validate my changes and merge them if they are acceptable.

@msrose
Copy link
Owner

msrose commented Jul 16, 2018

So the way this normally happens on GitHub is you'll fork this repository so you end up with your own copy that you have write access to. Then you can make a pull request from your fork to the master branch on this repo. Then I'd be happy to review the changes :) Let me know if you run into any problems and I can point you in the right direction.

@FransBosuil
Copy link
Contributor Author

Thank you for the info. PR #53 is available for review.

@msrose
Copy link
Owner

msrose commented Jul 19, 2018

Addressed in #53

@msrose msrose closed this as completed Jul 19, 2018
@msrose
Copy link
Owner

msrose commented Jul 19, 2018

Available in version 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants