Support CommonJS style requires

[chrislegault]

We have been writing our code in the CommonJS style as documented in the RequireJS area https://requirejs.org/docs/commonjs.html which doesn't seem like that style works in this plugin. I'm not a babel expert but I could try submitting a PR if it is something worthy to be included.

define(function (require) {
    var foo = require('foo');

    //Define this module as exporting a function
    return function () {
        foo.doSomething();
    };
});

[msrose]

Hmm the simplified commonjs wrapper is supposed to be supported, it's not documented in the README but there are a bunch of test cases which describe how it gets transformed. Have you tried the plugin out in your environment? It's possible there are some bugs with the commonjs wrapper transformation since I don't think its usage is very common, so if you could post any specific errors you encounter that would be great.

[chrislegault]

Oh really? I was still seeing errors but it could be my set up. EDIT - Yeah I see you've got tests for the style I use. So probably my fault.

[chrislegault]

Yup, sorry was me. Works!

[msrose]

Awesome good to hear! Glad someone is actually making use of the simplified commonjs wrapper stuff :)