Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the solidity compilation warnings shown at compile time #142

Closed
alsco77 opened this issue Mar 1, 2021 · 0 comments
Closed

Clean up the solidity compilation warnings shown at compile time #142

alsco77 opened this issue Mar 1, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@alsco77
Copy link
Contributor

alsco77 commented Mar 1, 2021

Is your feature request related to a problem? Please describe.
Run yarn compile and you will see a LOT of yellow warning text show up. Some of these are very very minor, some can potentially come into a larger issue.

Describe the solution you'd like
Resolve all of these warnings by modifying the solidity code, or add rules to the compiler to dismiss them, such that we have no warnings left when compilation happens.

Additional context
There is no real reason to receive warnings for the contracts in z_mocks since they are unused - these can simply be turned off.

@alsco77 alsco77 added good first issue Good for newcomers P3 labels Mar 1, 2021
@alsco77 alsco77 changed the title Clean up the solidity linting errors shown at compile time Clean up the solidity compilation warnings shown at compile time Mar 1, 2021
@alsco77 alsco77 closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant