Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Zoomify Images #154

Closed
dve opened this issue May 5, 2017 · 8 comments
Closed

Support for Zoomify Images #154

dve opened this issue May 5, 2017 · 8 comments

Comments

@dve
Copy link
Contributor

dve commented May 5, 2017

Hi,
I tried to add support for Leaflet.Zoomify but I failed :-(
Could you maybe take a look on it and give me a hint?
My try is located here: https://github.com/vegetweb/v-leaflet-zoomify and https://github.com/vegetweb/g-leaflet-zoomify

Thanks

Daniel

@mstahv
Copy link
Owner

mstahv commented Sep 7, 2017

I quickly tried this, but it gave me some JS exceptions about missing g parameter. All look good to me. Maybe an issue with the latest Leaflet? The Zoomify plugin itself looks bit old.

Maybe you could use the basic tile layer instead? Don't know what is the easiest way to create tilesets though, Zoomify might be easier to use than other solutions.

@dve
Copy link
Contributor Author

dve commented Sep 7, 2017

The layer works with the latest leaflet (1.2.0): https://github.com/vegetweb/zoomify-demo

We already have al large amount of pictures as zoomify tiles, so we can not change this.

@mstahv
Copy link
Owner

mstahv commented Sep 7, 2017

OK, then it is hopefully just a matter of updating the v-leaflet to have latest LeafletJS. I have had no time to look at any community efforts lately :-( I'll try to look at this later today.

@dve
Copy link
Contributor Author

dve commented Sep 7, 2017

The error keeps the same with leaflet 1.2.0

@mstahv
Copy link
Owner

mstahv commented Sep 7, 2017

It sure wasn't version conflict. Had to take one beer and debug this. It was actually just one cast missing -> call was going to wrong method -> it tried to create normal tile layer.

Change this line into this:

return ZoomifyLayer.create(getState().url, (ZoomifyLayerOptions) o);

@mstahv
Copy link
Owner

mstahv commented Sep 7, 2017

BTW. I'd suggest to use this archetype as a basis for the v-leaflet-zoomify addon: https://github.com/viritin/archetype-vaadin-gwt-addon Makes development and debugging much easier than with the "official" widget archetype.

@dve
Copy link
Contributor Author

dve commented Sep 8, 2017

Thank you and your beer a lot! If you come to north or north-eastern germany I would be glad to return the beer to you.

I will look at the new archtype and update the addon before submitting it.

Why is the "handy" stuff not the official one a vaadin?

@dve
Copy link
Contributor Author

dve commented Sep 11, 2017

I've made all the changes and published to vaadin directory. The code has moved to https://github.com/infinitenature/v-leaflet-zoomify

Thanks a lot!

@dve dve closed this as completed Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants