Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAG_End as type for empty lists #12

Closed
NiclasOlofsson opened this issue Mar 31, 2015 · 5 comments
Closed

TAG_End as type for empty lists #12

NiclasOlofsson opened this issue Mar 31, 2015 · 5 comments
Labels

Comments

@NiclasOlofsson
Copy link

According to the "spec" at http://minecraft.gamepedia.com/NBT_format

"It may also be the type of empty List tags."

In the code for NbtList it doesn't allow END tags as type for the list hence barfs on some (many) region files.

@mstefarov
Copy link
Owner

Thanks for bringing this to my attention, Niclas! I was not aware of this quirk. I'll have it fixed this week.

@mstefarov mstefarov added the bug label Mar 31, 2015
@NiclasOlofsson
Copy link
Author

I can provide a pull for the fix if that helps speed up the release? About 50% of the worlds loding are affected by this right now. But i guess that the actual "fix" is not what takes time, right?

@mstefarov
Copy link
Owner

The hard part is finding the time :)

A quick fix (in the pull request) is possible, but I need to check for side effects, and add various sanity checks and unit tests (for example, it should not be possible to have a non-empty list of end-tags). And then package and distribute it.

I expect to have it all done within 24 hours though. I'm sorry about the wait!

@NiclasOlofsson
Copy link
Author

Yeah, was a very dirty quick fix :-) The changes you made looks good. I'll wait for it to update NuGet and then test it.

@mstefarov
Copy link
Owner

NuGet update was just pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants