Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement ifquery doesn't fail for unconfigured bridge #120

Open
sshambar opened this issue Jun 8, 2021 · 0 comments
Open

Replacement ifquery doesn't fail for unconfigured bridge #120

sshambar opened this issue Jun 8, 2021 · 0 comments

Comments

@sshambar
Copy link

sshambar commented Jun 8, 2021

When mstp_config_bridge calls ifquery, it checks the return code to see if a bridge has been configured. However, the replacement ifquery program always succeeds (but returns an empty string).

A fix could either be to either:

  • make ifquery fail for unconfigured bridges
  • update mstp_config_bridge to check the $? as well that a value was returned.
  • both :)

I'm happy to supply a patch for any of the above if you think it's something useful.

@sshambar sshambar changed the title Replacement ifquery doesn't fail for unknown bridge Replacement ifquery doesn't fail for unconfigured bridge Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant