Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Remove landscape failures #88

Merged
merged 3 commits into from Oct 10, 2018
Merged

Remove landscape failures #88

merged 3 commits into from Oct 10, 2018

Conversation

syre
Copy link
Contributor

@syre syre commented Oct 9, 2018

PR for removing some of the code health failures from Landscape:

  • use new-style classes
  • specify string format arguments as logging function parameters
  • remove deprecated load_stylesheet_pyqt5 and replace with load_stylesheet

@coveralls
Copy link

coveralls commented Oct 9, 2018

Coverage Status

Coverage remained the same at 24.981% when pulling 0009481 on syre:remove-landscape-failures into db3ba28 on pynocchio:develop.

@syre
Copy link
Contributor Author

syre commented Oct 9, 2018

@mstuttgart i believe the logging call are correct as this is the way to do string substitution in logging (as argument) https://docs.python.org/3/library/logging.html#logging.Logger.debug

@mstuttgart
Copy link
Owner

Sorry @syre . You're right: https://fangpenlin.com/posts/2012/08/26/good-logging-practice-in-python/

@mstuttgart
Copy link
Owner

Greate work @syre . Please fix the flake8 errors: https://travis-ci.org/pynocchio/pynocchio/jobs/439123980#L743

@syre
Copy link
Contributor Author

syre commented Oct 10, 2018

Thanks @mstuttgart i have done so now

@mstuttgart mstuttgart merged commit 34263d0 into mstuttgart:develop Oct 10, 2018
@mstuttgart mstuttgart removed their request for review October 10, 2018 09:52
@syre syre deleted the remove-landscape-failures branch October 10, 2018 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants