Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

iSC/GAPS/Cold Chain: 'Edit' button does not appear for Remote Sites after initialising GAPS #4262

Closed
marthakeezy opened this issue Jun 24, 2024 · 1 comment
Assignees
Labels
bug Something is borken feature: GAPS Team Piwakawaka Mark, James, Fergus
Milestone

Comments

@marthakeezy
Copy link

What went wrong? 馃槻

After initialising GAPS on Central Server, I noticed the 'Edit' button did not appear for my Remote Site after synchronising. It only appeared after closing the app and logging out and in again.

Expected behaviour 馃

The button should appear for Remote Sites straight after synchronisation, not after logging out and in again.

How to Reproduce 馃敤

Steps to reproduce the behaviour:

  1. Have your Central Server set up and a Remote Site to test
  2. Initialise GAPS on Central Server
  3. Go to your Remote Site -> make sure you are logged in prior to testing -> synchronise
  4. See the issue - the 'Edit' button does not appear
  5. Log out and in again
  6. See the 'Edit' button appear now

Your environment 馃尡

  • Open mSupply Version: V2.1.0-RC3
  • Legacy mSupply Central Server Version: V7.15.05
  • Platform: Desktop App on Windows (Central Server) & Galaxy A8 Tablet app (Remote Site)
  • Database type: SQLite3
@marthakeezy marthakeezy added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. labels Jun 24, 2024
@CarlosNZ CarlosNZ removed the needs daily triage New bug to be triaged by the release team label Jun 25, 2024
@mark-prins mark-prins added Team Piwakawaka Mark, James, Fergus feature: GAPS and removed Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. labels Jun 25, 2024
@lache-melvin lache-melvin added this to the v2.1.0-rc4 milestone Jun 25, 2024
@lache-melvin lache-melvin self-assigned this Jun 26, 2024
@lache-melvin
Copy link
Contributor

Going to close this one - its similar to the discussion in #3696, but I think even more edge case...

When remote syncs, we don't invalidate any data (though we are working towards this design eventually) - so the footer doesn't immediately know to update.

However, you don't even need to log out and in again, just navigating to another page seems to do it for me. Given it's a one time set up, I don't see this being an issue, and may be resolved in future with some kind of post-sync invalidation step

@lache-melvin lache-melvin closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
@roxy-dao roxy-dao modified the milestones: v2.1.0-rc4, V2.1.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken feature: GAPS Team Piwakawaka Mark, James, Fergus
Projects
None yet
Development

No branches or pull requests

5 participants