Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iSC/GAPS/Cold Chain: inconsistent House Icon 🏠 display under 'Facilities' #4270

Closed
marthakeezy opened this issue Jun 25, 2024 · 2 comments · Fixed by #4327
Closed

iSC/GAPS/Cold Chain: inconsistent House Icon 🏠 display under 'Facilities' #4270

marthakeezy opened this issue Jun 25, 2024 · 2 comments · Fixed by #4327
Assignees
@mark-prins
Labels
bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. feature: GAPS Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... Team Piwakawaka Mark, James, Fergus Tester: Maria
Milestone
V2.1.0

Comments

@marthakeezy
Copy link

marthakeezy commented Jun 25, 2024 •
edited
Loading

What went wrong? 😲

When changing the number of facilities shown per page, the house icon 🏠 is shown inconsistently.

Error captured on this video :)

Expected behaviour 🤔

I am not sure we need to have a house icon all together - the list only shows stores, right? If we decide to keep it, it should be displayed consistently

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to Manage -> Facilities
  2. Change the number of rows displayed per page from 20 to 50 to 500 (play around)
  3. See inconsistency

Your environment 🌱

  • Open mSupply Version: V2.1.0-RC3
  • Legacy mSupply Central Server Version: V7.15.05
  • Platform: Desktop App on Windows
  • Database type: SQLite 3
@marthakeezy marthakeezy added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... labels Jun 25, 2024
@marthakeezy marthakeezy mentioned this issue Jun 25, 2024
Closed
41 tasks
@andreievg andreievg added needs daily triage New bug to be triaged by the release team and removed needs daily triage New bug to be triaged by the release team labels Jun 25, 2024
@andreievg andreievg removed needs triage needs daily triage New bug to be triaged by the release team labels Jun 27, 2024
@andreievg
Copy link
Collaborator

Triage, very small fix to just remove the column because they are all stores. Squeeze into 2.1

@andreievg andreievg added the Team Piwakawaka Mark, James, Fergus label Jun 27, 2024
@andreievg andreievg added this to the v2.1.0-rc5 milestone Jun 27, 2024
@mark-prins mark-prins self-assigned this Jul 1, 2024
@mark-prins mark-prins mentioned this issue Jul 1, 2024
Merged
5 tasks
@roxy-dao roxy-dao modified the milestones: v2.1.0-rc5, V2.1.0 Jul 2, 2024
@marthakeezy
Copy link
Author

No more houses!! Build test passed ✅

@marthakeezy marthakeezy added Build Tested: Passed Issue has been build tested with all tests passed. Tester: Maria labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-prins mark-prins

Labels
bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. feature: GAPS Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... Team Piwakawaka Mark, James, Fergus Tester: Maria
Projects
None yet
Milestone
V2.1.0
Development

Successfully merging a pull request may close this issue.

Facility list house icon msupply-foundation/open-msupply
4 participants
@mark-prins @andreievg @roxy-dao @marthakeezy