Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove selection column for remote sites #4288

Merged

Conversation

lache-melvin
Copy link
Contributor

Fixes #4286

πŸ‘©πŸ»β€πŸ’» What does this PR do?

For all sites except central server, hide the select column in asset catalogue:

Screenshot 2024-06-26 at 6 12 52β€―PM

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • On central server, catalogue > assets, you can see the select column
  • On remote site, catalogue > assets, you CANNOT see the select column

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added bug Something is borken feature: coldchain Team Piwakawaka James, Fergus, LachΓ©, Chris Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... labels Jun 26, 2024
@lache-melvin lache-melvin linked an issue Jun 26, 2024 that may be closed by this pull request
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
8.83 MB 8.83 MB 68 B (0.00%)

Copy link
Contributor

@roxy-dao roxy-dao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ /o/

@roxy-dao roxy-dao self-assigned this Jun 26, 2024
@lache-melvin lache-melvin merged commit 398b6ec into release-v2.1.0 Jun 26, 2024
5 checks passed
@lache-melvin lache-melvin deleted the 4286-remove-asset-select-column-on-remote branch June 26, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken feature: coldchain Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... Team Piwakawaka James, Fergus, LachΓ©, Chris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iSC/Cold Chain: remove checkboxes if no actions can be performed
2 participants